[fix][client] Fix OpenTelemetryProducerInterceptor not executing due to eligible check#25585
Merged
Merged
Conversation
…to eligible check
Contributor
Author
|
@Technoboy- @lhotari @codelipenghui @poorbarcode Could you please review this PR? Thanks |
added 2 commits
May 7, 2026 17:46
added 2 commits
May 11, 2026 11:27
Technoboy-
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25584
Motivation
OpenTelemetryProducerInterceptor had a deadlock:
The interceptor was effectively a no-op — it never created any spans.
Modifications
Remove the lazy-initialization pattern and inject InstrumentProvider at construction time instead. The InstrumentProvider is already available in both ProducerBuilderImpl and ConsumerBuilderImpl where the interceptors are created:
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes